feat: manage database schema via alembic#119
Merged
MateoLostanlen merged 6 commits intomainfrom May 1, 2026
Merged
Conversation
Replace SQLModel.metadata.create_all with alembic upgrade head in all compose entrypoints. Drop init_db from app.db and from main.py lifespan. Add make migrate / migrate-up wrappers.
Address review feedback: PostgreSQL enum types are not removed by op.drop_table, so a downgrade-then-upgrade cycle would fail with duplicate enum errors. Also enable compare_type=True in the online migration context so autogenerate detects column type changes.
# Conflicts: # annotation_api/Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLModel.metadata.create_allwith Alembic migrations as the sole owner of the DB schema. Containers now runalembic upgrade headon startup; an autogenerated initial revision captures all current tables, indexes and enums.pyro-apimigration layout:src/migrations/{env.py, script.py.mako, versions/}, withAutoStringrendered as plainsa.Stringso revision files don't import sqlmodel.alembic upgrade headso tests exercise the same migration path as production. All 331 tests pass.make migrate m="..."(autogenerate) andmake migrate-up(apply) wrappers, mirroringpyro-api.