feat(sequences-review): add stage selector with seq_annotation_done default#122
Open
MateoLostanlen wants to merge 2 commits intomainfrom
Open
feat(sequences-review): add stage selector with seq_annotation_done default#122MateoLostanlen wants to merge 2 commits intomainfrom
MateoLostanlen wants to merge 2 commits intomainfrom
Conversation
…efault Route /sequences/review now exposes a stage dropdown covering seq_annotation_done (default), in_review, annotated, needs_manual. The selected stage is persisted across reloads via localStorage. Review-specific UI (model accuracy, smoke/FP filters, unsure, legend, row coloring) stays gated on the annotated stage; the page behaves like /sequences/annotate for the other three stages.
…a effect
- Replace implicit isReviewPage = (stageSelector !== undefined) with an
explicit boolean prop so behavior is decoupled from the UI prop.
- Drop the key={stage} remount; sync filters.processing_stage via a
useEffect that resets pagination on stage change. Avoids losing
in-flight query state on stage switches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/sequences/reviewpreviously listed onlyannotatedsequences. It now exposes a stage dropdown coveringSeq annotation done(default),In review,Annotated, andNeeds manual, with the choice persisted in localStorage.annotated, behavior is unchanged (model accuracy, smoke/FP type filters, unsure filter, legend, row coloring). For the other three stages, the page mirrors/sequences/annotate(plain list).filters.processing_stagevia auseEffect, resetting pagination on switch; user filters (date range, camera, etc.) persist across stage changes.isReviewPageprop replaces the implicit "stageSelector defined" flag;key={stage}remount removed in favor of the effect.Verified via
tsc --noEmit,eslint(no new warnings), andvitest(615/615). Full UI walkthrough was not run since the Docker stack was not started locally.