Skip to content

Adapt camera-proxy to new pyro-camera-api client#569

Open
MateoLostanlen wants to merge 2 commits intomainfrom
update_camera_proxy
Open

Adapt camera-proxy to new pyro-camera-api client#569
MateoLostanlen wants to merge 2 commits intomainfrom
update_camera_proxy

Conversation

@MateoLostanlen
Copy link
Copy Markdown
Member

Summary

After upted in pyro-camera-api client

  • Aligns /cameras/{id}/... proxy routes with the refreshed pyro_camera_api_client: renames pos_id → patrol_id on /capture, and adds duration / zoom
    to the legacy /control/move.
  • Exposes the new focused PTZ endpoints (preferred over the overloaded move): goto_preset, start_move, stop_move, move_for_duration, move_by_degrees,
    click_to_move, plus GET /control/speed_tables.
  • speed on /control/move_by_degrees is optional — when omitted the device auto-picks the best calibrated speed (preferred).
  • Temporarily pins pyro-camera-api-client to the calibrate_reolink_cam branch until those client changes land on develop; switch back before merge.

Rename pos_id to patrol_id on /capture, add duration/zoom to legacy
/control/move, and expose focused PTZ endpoints (goto_preset,
start_move, stop_move, move_for_duration, move_by_degrees,
click_to_move) plus /control/speed_tables.
Aligns with the client change where omitting speed lets the server
auto-pick the best calibrated level for the target angle.
@MateoLostanlen MateoLostanlen requested a review from fe51 April 16, 2026 11:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.80%. Comparing base (0790626) to head (5dd4c61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   88.21%   87.80%   -0.41%     
==========================================
  Files          51        3      -48     
  Lines        2163      123    -2040     
==========================================
- Hits         1908      108    -1800     
+ Misses        255       15     -240     
Flag Coverage Δ
backend ?
client 87.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant