fix: keep alert id stable when labeling a solo sequence FP#584
Draft
MateoLostanlen wants to merge 3 commits intomainfrom
Draft
fix: keep alert id stable when labeling a solo sequence FP#584MateoLostanlen wants to merge 3 commits intomainfrom
MateoLostanlen wants to merge 3 commits intomainfrom
Conversation
When a sequence labeled non-wildfire is the only one in its alert, the previous logic detached it, deleted the alert (now empty), and created an identical replacement — changing the alert id for no gain. Multi-sequence alerts still split so the FP no longer contributes to triangulation.
Adds an integration test asserting the alert id is preserved when labeling a single-sequence alert as non-wildfire, and a unit test for the same path. Updates the existing multi-sequence unit test to mock the new siblings probe.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 89.80% 89.82% +0.02%
==========================================
Files 55 55
Lines 2422 2427 +5
==========================================
+ Hits 2175 2180 +5
Misses 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIMIT 1siblings probe and the alert is left untouched.