feat(sequences): re-run cone matching when relabeling back to wildfire_smoke#585
Draft
MateoLostanlen wants to merge 4 commits intomainfrom
Draft
feat(sequences): re-run cone matching when relabeling back to wildfire_smoke#585MateoLostanlen wants to merge 4 commits intomainfrom
MateoLostanlen wants to merge 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 55 55
Lines 2422 2432 +10
=======================================
+ Hits 2175 2184 +9
- Misses 247 248 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
other_smoke), it's detached from its triangulating alert and a fresh single-sequence alert is created. Reverting the label towildfire_smokepreviously left the sequence stuck in that lonely alert, breaking triangulation. This PR makes the revert path drop the lonely alert and re-run cone matching so the sequence merges back with its overlapping neighbours.last_seen_at(notutcnow()) so relabels done hours later still find the original neighbours withinSEQUENCE_RELAXATION_SECONDS._attach_sequence_to_alert→attach_sequence_to_alertand extract_detach_sequence_from_alertsto deduplicate the detach/refresh block.