Skip to content

Skip no-commit-to-branch prek hook in CI#1333

Merged
david-yz-liu merged 1 commit intomasterfrom
fix/prek-ci-no-commit-to-branch
Apr 15, 2026
Merged

Skip no-commit-to-branch prek hook in CI#1333
david-yz-liu merged 1 commit intomasterfrom
fix/prek-ci-no-commit-to-branch

Conversation

@david-yz-liu
Copy link
Copy Markdown
Contributor

@david-yz-liu david-yz-liu commented Apr 15, 2026

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

The hook incorrectly fails when CI runs on push to master after merging a PR. Skipping it in CI is safe since the hook is only meaningful as a local safeguard.

This PR was co-authored by Claude Sonnet 4.6.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

The hook incorrectly fails when CI runs on push to master after merging a PR.
Skipping it in CI is safe since the hook is only meaningful as a local safeguard.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 24457544945

Coverage remained the same at 89.995%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3868
Covered Lines: 3481
Line Coverage: 89.99%
Coverage Strength: 17.45 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 61414fd into master Apr 15, 2026
30 checks passed
@david-yz-liu david-yz-liu deleted the fix/prek-ci-no-commit-to-branch branch April 15, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants