fix: add non-concurrent index creation migrations#579
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Concurrently in auction creation time idx migration
Contributor
Author
|
After merging, we should run the following two queries to add the migrations to the The checksums are matched against the result of running these migrations locally. |
danimhr
approved these changes
Jul 31, 2025
Contributor
danimhr
left a comment
There was a problem hiding this comment.
Do we need to update the migrate down file as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
concurrentlyfrom the migration query to add an index oncreation_timeto the postgresauctiontable. This is so that the migrations in_sqlx_migrationscan remain consistent between local and the prod db.On local, we run this migration via the normal path since we aren't worried about downtime. However, on the prod db we had to run the migration manually in psql due to the risk of significant downtime from running this query (moreover, sqlx doesn't easily support running queries
concurrently).In the prod version, we manually appended an entry to the
_sqlx_migrationstable with the checksum corresponding to the query file to indicate that the migration has taken place.This PR also adds an index on the
auction_idin thebidtable; without this, the deletes cannot happen quickly due to theON DELETE RESTRICTclause. Similar to above, the index was created concurrently, but the migration file shows a blocking index creation.