Unifying ResponseMatrix, hide pySC from pyAML API#216
Conversation
gubaidulinvadim
left a comment
gubaidulinvadim
left a comment
There was a problem hiding this comment.
I think this is a positive change. It would perhaps be good to define some abstract interface for response matrices. I think many of the steps are the same for tune, orbit and chromaticity, not only saving and loading from a file.
|
Right, this is only a first step. |
|
|
||
| @property | ||
| def reponse_matrix(self) -> ResponseMatrix | None: | ||
| return self._cfg.response_matrix |
There was a problem hiding this comment.
I don't understand this property, because _pySC_response_matrix holds almost all of the information.
Is it in anticipation that a pyaml ResponseMatrix holds inside of it a _pySC_response_matrix, and then everything goes through the "pyaml" ResponseMatrix?
There was a problem hiding this comment.
Yes this is the idea
There was a problem hiding this comment.
pySC should not appear to the end user neither methods, neither internal structure.
There was a problem hiding this comment.
I also currently thinking how to have a base class ResponseMatrix with basically only common field and having specific response matrices. For instance, i would like to not see the rf_respone in the base class.
3 participants
This PR is a very first step toward unification of various response matrices and hiding pySC from pyAML API.