Skip to content

30 modular linking between pyat and pyaml elements#32

Merged
JeanLucPons merged 5 commits intomainfrom
30-modular-linking-between-pyat-and-pyaml-elements
Oct 15, 2025
Merged

30 modular linking between pyat and pyaml elements#32
JeanLucPons merged 5 commits intomainfrom
30-modular-linking-between-pyat-and-pyaml-elements

Conversation

@gupichon
Copy link
Contributor

Closes #30

@gupichon gupichon requested a review from JeanLucPons October 14, 2025 14:05
@gupichon gupichon linked an issue Oct 14, 2025 that may be closed by this pull request
6 tasks
Copy link
Contributor

@JeanLucPons JeanLucPons Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to replace the FamNameElementsLinker by something like ElementsLinker("FamName") ?
So the default linker can be also used easliy to choose the pyAT attribute name to use.
I would except the attribute name in the ConfigModel with a default to FamName.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to replace the FamNameElementsLinker by something like ElementsLinker("FamName") ?

I'm working on it. It's a bit tricky with the ConfModel...


I would except the attribute name in the ConfigModel with a default to FamName.

I thought about that, but it's actually unnecessary since it behaves the same as not setting a linker at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, I can completly remove the FamNameElementsLinker, it's useless.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, I can completly remove the FamNameElementsLinker, it's useless.

With a default ElementsLinker with FamName as default, yes FamNameElementsLinker become useless.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename get_at_element() to get_first_at_element() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this method is to ensure unicity.
If you want the first of a group, you can just call get_at_elements()[0]
This method may be useless but it will depends of future developpements.

Copy link
Contributor

@JeanLucPons JeanLucPons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make default linker configurable with the pyAT attribute name to use.

@gupichon
Copy link
Contributor Author

Make default linker configurable with the pyAT attribute name to use.

Isn't that the same as specifying the linker with attribute_linker and providing the desired name?
I don't think it would be a real improvement...

@JeanLucPons
Copy link
Contributor

Make default linker configurable with the pyAT attribute name to use.

Isn't that the same as specifying the linker with attribute_linker and providing the desired name? I don't think it would be a real improvement...

Your modification using:

PyAtAttributeElementsLinker(PyAtAttrLinkerConfigModel(attribute_name="FamName"))

is OK for me.

@JeanLucPons JeanLucPons merged commit be8b5d0 into main Oct 15, 2025
2 checks passed
@gubaidulinvadim gubaidulinvadim deleted the 30-modular-linking-between-pyat-and-pyaml-elements branch December 17, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modular linking between PyAT and PyAML elements

3 participants