Added missing attribute_read_only in dummy-cs#47
Merged
JeanLucPons merged 2 commits intomainfrom Oct 23, 2025
Merged
Conversation
Contributor
|
I've tried to run the tests locally on this branch. Many of them failed with the following short errors summary: If I switch to main branch every test passes again. So, maybe there's some problem with dummy_cs. |
Contributor
Author
|
Hmm, this is strange. Your are running on a true control system this time. |
Contributor
|
OK, there's a conflict with package pytango somehow. I uninstalled pytango from pip and the tests are now passing. With reinstallation of pytango the tests also pass. So, this is just the fragility of my own python environment. |
gubaidulinvadim
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing attribute_read_only in dummy-cs
Corrected BPM config with read only attribute