Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/1287.change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixed `attrs.frozen` classes not working with `enum.Enum` subclasses.

When creating an Enum subclass of a frozen attrs class, the frozen `__setattr__` would prevent Enum from creating members. Now, Enum instances can bypass the frozen check to allow proper member creation.
6 changes: 6 additions & 0 deletions src/attr/_make.py
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,12 @@ def _frozen_setattrs(self, name, value):
BaseException.__setattr__(self, name, value)
return

# Allow Enum subclasses to set attributes during member creation.
# Enum needs to set _name_, _value_, etc. when creating members.
if isinstance(self, enum.Enum):
object.__setattr__(self, name, value)
return

raise FrozenInstanceError


Expand Down
66 changes: 66 additions & 0 deletions tests/test_functional.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import pickle

from copy import deepcopy
from enum import Enum

import pytest

Expand Down Expand Up @@ -816,3 +817,68 @@ def test_invalid_field_name(self):

with pytest.raises(TypeError):
copy.replace(inst, z=42)


class TestEnum:
"""
Tests for Enum + attrs interaction (issue #1287).
"""

def test_define_enum(self):
"""
attrs.define works with Enum subclasses.

Enum members can be created and attrs fields are accessible.
"""

@attr.define
class AttrsDefine:
x: int
y: float

class AttrsDefineEnum(AttrsDefine, Enum):
A = (1, 2.0)
B = (3, 4.0)

assert 1 == AttrsDefineEnum.A.x
assert 2.0 == AttrsDefineEnum.A.y
assert 3 == AttrsDefineEnum.B.x
assert 4.0 == AttrsDefineEnum.B.y

def test_frozen_enum(self):
"""
attrs.frozen works with Enum subclasses.

Enum members can be created even with frozen base classes.
"""

@attr.frozen
class AttrsFrozen:
x: int
y: float

class AttrsFrozenEnum(AttrsFrozen, Enum):
A = (1, 2.0)
B = (3, 4.0)

assert 1 == AttrsFrozenEnum.A.x
assert 2.0 == AttrsFrozenEnum.A.y
assert 3 == AttrsFrozenEnum.B.x
assert 4.0 == AttrsFrozenEnum.B.y

def test_frozen_enum_is_hashable(self):
"""
attrs.frozen Enum subclasses are hashable.
"""

@attr.frozen
class AttrsFrozen:
x: int

class FrozenEnum(AttrsFrozen, Enum):
A = (1,)
B = (2,)

# Should not raise TypeError
hash(FrozenEnum.A)
hash(FrozenEnum.B)