No longer setting parser's prog value in with_argparser().#1462
Merged
kmvanbrunt merged 1 commit intomainfrom Jul 12, 2025
Merged
No longer setting parser's prog value in with_argparser().#1462kmvanbrunt merged 1 commit intomainfrom
kmvanbrunt merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
- Coverage 98.50% 98.50% -0.01%
==========================================
Files 20 20
Lines 5605 5603 -2
==========================================
- Hits 5521 5519 -2
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
requested changes
Jul 12, 2025
Member
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Please add a breaking change note to the CHANGELOG
…ts set in Cmd._build_parser().
kmvanbrunt
force-pushed
the
not_setting_prog
branch
from
ec9a2fc to
2c08b79
Compare
tleonhardt
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer setting parser's prog value in with_argparser() since it gets set in Cmd._build_parser().
This code had previously been restored to support backward compatibility in cmd2 2.0 family.
Now that we are moving to cmd2 3.0, it can be removed.