Enabled all printing methods to support Rich objects.#1471
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
==========================================
+ Coverage 98.41% 98.77% +0.35%
==========================================
Files 21 21
Lines 5868 5878 +10
==========================================
+ Hits 5775 5806 +31
+ Misses 93 72 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
left a comment
There was a problem hiding this comment.
Overall looks good. Mainly need to update CHANGELOG and documentation. But various comments, at least some of which should likely be addressed.
theagilehacker
left a comment
There was a problem hiding this comment.
I learned a couple of new Python tricks reviewing this change.
I am still not quite versed in the code base enough to grok it enough to make any design/code suggestions, other than logic issues, of which there are non that I could see.
67fc886 to
ee44321
Compare
ee44321 to
05c8b66
Compare
05c8b66 to
7034777
Compare
tleonhardt
left a comment
There was a problem hiding this comment.
I like how you parameterized the chop argument in the one unit test.
LGTM
No description provided.