Merged
Conversation
mik-laj
commented
Mar 19, 2025
| if not hasattr(settings, "OPENAPI"): | ||
| if not hasattr(settings, "OPENAPI_SPEC"): | ||
| raise ImproperlyConfigured( | ||
| "OPENAPI_SPEC not defined in settings" |
Contributor
Author
There was a problem hiding this comment.
OPENAPI_SPEC is a depreacted, so we should suggest to use OPENAPI.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #976 +/- ##
==========================================
+ Coverage 90.36% 90.62% +0.26%
==========================================
Files 148 150 +2
Lines 4328 4374 +46
Branches 529 532 +3
==========================================
+ Hits 3911 3964 +53
- Misses 316 318 +2
+ Partials 101 92 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p1c2u
reviewed
Mar 19, 2025
p1c2u
approved these changes
Mar 19, 2025
Collaborator
p1c2u
left a comment
p1c2u
left a comment
There was a problem hiding this comment.
Just one suggestion otherwise looks good 💪
Co-authored-by: Artur Maciag <maciag.artur@gmail.com>
Collaborator
|
Thank you for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have a project where I would like to be able to configure specifications for each view separately, because we have several API variants, and therefore several specification files.
This is very inspired by the approach used by Flask integrations.
Best regards,
Kamil Breguła