Allow Starlette 0.45 and 0.46#977
Merged
p1c2u merged 2 commits intopython-openapi:masterfrom Mar 22, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 150 150
Lines 4374 4374
Branches 532 532
=======================================
Hits 3964 3964
Misses 318 318
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p1c2u
approved these changes
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starlette 0.45 drops Python 3.8 support, removes
ExceptionMiddlewarefromstarlette.exceptions, and removesWS_1004_NO_STATUS_RCVDandWS_1005_ABNORMAL_CLOSURE: https://github.com/encode/starlette/releases/tag/0.45.0Starlette 0.46 renames
max_file_sizetospool_max_sizeinMultiPartParser: https://github.com/encode/starlette/releases/tag/0.46.0None of that should affect openapi-core.
Even with this PR, Starlette would still be stuck at
0.44.0inpoetry.lockuntil openapi-core drops support for Python 3.8.I didn’t try to drop Python 3.8 support in this PR, but just to check, I tried a local experiment:
I then ran
poetry update starletteand confirmed that the tests do still pass with Starlette 0.46.1.