Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 24 24
Lines 742 742
Branches 83 83
=======================================
Hits 682 682
Misses 39 39
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Rebased on |
Contributor
Author
|
@p1c2u I hope you're doing well! I wanted to ping you and ask if you could review some of these open PRs? |
The following changes are introduced: * Update the list of Python versions to test (3.9+) * Remove the now-unused `default` and `simplejson` factors * Switch to Poetry for dependency installation * Switch to running pytest to execute the test suite
Contributor
Author
|
Rebased on @p1c2u This is ready for review. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
It updates the tox config so that it can run.
The
setup.pyfile is gone, as are therequirements.txtfiles. Poetry is invoked to install the dependencies now.It updates the list of Python versions to run the test suite against.
It removes the now-unused
defaultandsimplejsonfactorsTaken together, these changes allow developers to run the test suite locally before submitting PRs to the project.