Skip to content

Duration deepcopy fix #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abdu11ahBilal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Duration deepcopy fix #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pendulum/duration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ def __deepcopy__(self, _: dict[int, Self]) -> Self:
hours=self.hours,
years=self.years,
months=self.months,
weeks=self.weeks,
)


Expand Down
14 changes: 11 additions & 3 deletions tests/duration/test_behavior.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
from copy import deepcopy
from datetime import timedelta

import pytest

import pendulum

from tests.conftest import assert_duration
Expand All @@ -24,9 +26,15 @@ def test_comparison_to_timedelta() -> None:
assert duration < timedelta(days=4)


def test_deepcopy() -> None:
duration = pendulum.duration(months=1)
@pytest.mark.parametrize(
"duration, expected",
[
(pendulum.duration(months=1), {"months": 1}),
(pendulum.Duration(days=9), {"weeks": 1, "days": 2}),
],
)
def test_deepcopy(duration, expected) -> None:
copied_duration = deepcopy(duration)

assert copied_duration == duration
assert_duration(copied_duration, months=1)
assert_duration(copied_duration, **expected)