perf: caching

[radoering]

Two caching changes that improve performance for resolving large projects a bit:

• Apparently, Term.relation and Term.intersection is often not used and constructing the cache in __init__ costs some time. The trick with the cached_property seems simple enough and effective. In case anyone is wondering if we should apply this trick in general: It only makes sense for classes if many instances of the class are created and the cached methods are not used in many instances. We do not create that many instances of other classes where instance methods are cached.
• _find_packages seems to be called with the same name and constraint multiple times, especially when resolving with overrides.

[sourcery-ai]

Hey - I've left some high level feedback:

• Wrapping _find_packages_uncached with functools.cache and assigning it to self._find_packages at runtime will bypass any overrides of _find_packages in subclasses; if subclassing is expected here, consider caching at the class/method level or providing an overridable hook instead.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Wrapping `_find_packages_uncached` with `functools.cache` and assigning it to `self._find_packages` at runtime will bypass any overrides of `_find_packages` in subclasses; if subclassing is expected here, consider caching at the class/method level or providing an overridable hook instead.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}