Skip to content

Commit e66808d

Browse files
committed
Bugfix: Changes view for old revisions
This fixes tobami#168.
1 parent bb4e36b commit e66808d

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

codespeed/views.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -677,9 +677,9 @@ def changes(request):
677677
executables[proj] = Executable.objects.filter(project=proj)
678678
projectlist.append(proj)
679679
branch = Branch.objects.filter(name=settings.DEF_BRANCH, project=proj)
680-
revisionlists[proj.name] = Revision.objects.filter(
680+
revisionlists[proj.name] = list(Revision.objects.filter(
681681
branch=branch
682-
).order_by('-date')[:revlimit]
682+
).order_by('-date')[:revlimit])
683683
# Get lastest revisions for this project and it's "default" branch
684684
lastrevisions = revisionlists.get(defaultexecutable.project.name)
685685
if not len(lastrevisions):
@@ -692,9 +692,8 @@ def changes(request):
692692
selectedrevision = Revision.objects.get(
693693
commitid__startswith=commitid, branch=branch
694694
)
695-
if not selectedrevision in lastrevisions:
696-
lastrevisions = list(chain(lastrevisions))
697-
lastrevisions.append(selectedrevision)
695+
if not selectedrevision in revisionlists[selectedrevision.project.name]:
696+
revisionlists[selectedrevision.project.name].append(selectedrevision)
698697
except Revision.DoesNotExist:
699698
selectedrevision = lastrevisions[0]
700699
# This variable is used to know when the newly selected executable

0 commit comments

Comments
 (0)