gh-122450: Expand documentation for Rational and Fraction#136800
gh-122450: Expand documentation for Rational and Fraction#136800AA-Turner merged 14 commits intopython:mainfrom
Rational and Fraction#136800Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Look also at the paragraph before the constructor description: "A Fraction instance can be constructed from a pair of integers, from another rational number, or from a string." It is outdated. The numbers in the pair can be not only integers, and the single numerical argument can be not only rational. Making it more precise will only lead to repetition, so I would make it more generic instead.
This comment was marked as resolved.
This comment was marked as resolved.
Rational and Fraction
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
I'll wait until tomorrow to merge in case others have comments. A |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Can you handle the backports? A |
|
Thanks @skirpichev for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @skirpichev and @AA-Turner, I could not cleanly backport this to |
|
Sorry, @skirpichev and @AA-Turner, I could not cleanly backport this to |
Sure, I will. |
…raction`` (pythonGH-136800) (cherry picked from commit b266fbc) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-137363 is a backport of this pull request to the 3.14 branch. |
…`` (python#136800) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit b266fbc)
…`` (python#136800) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit b266fbc)
|
GH-137367 is a backport of this pull request to the 3.13 branch. |
|
…`` (python#136800) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Hugo Sansaqua privet.kitty99@gmail.com
denominatorofFractionis positive, which should be documented #122450Links: