Skip to content

Strengthen warning against using 'import *' in tutorial#137011

Closed
yusuaois wants to merge 2 commits intopython:mainfrom
yusuaois:document
Closed

Strengthen warning against using 'import *' in tutorial#137011
yusuaois wants to merge 2 commits intopython:mainfrom
yusuaois:document

Conversation

@yusuaois
Copy link
Copy Markdown

@yusuaois yusuaois commented Jul 22, 2025

trivial fix:
In Doc/tutorial/modules.rst, the current wording about import * usage is not sufficiently strong:

- "However, it is okay to use it to save typing in interactive sessions."

This phrasing has two main issues:

- Understates risks: Framing it as "okay" minimizes the potential problems with wildcard imports

- Incomplete guidance: Fails to explicitly warn against using this pattern in production code

- Ambiguous justification: "Save typing" implies convenience is the primary consideration, ignoring namespace pollution risks

📚 Documentation preview 📚: https://cpython-previews--137011.org.readthedocs.build/

@AA-Turner
Copy link
Copy Markdown
Member

The current wording is fine. Please also read our AI policy.

A

@AA-Turner AA-Turner closed this Jul 22, 2025
@yusuaois yusuaois deleted the document branch July 23, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants