gh-137173: Allow signal handling in isolated subinterpreters#137174
Open
ZeroIntensity wants to merge 16 commits intopython:mainfrom
Open
gh-137173: Allow signal handling in isolated subinterpreters#137174ZeroIntensity wants to merge 16 commits intopython:mainfrom
ZeroIntensity wants to merge 16 commits intopython:mainfrom
Conversation
Also fix the existing test cases that were broken.
ZeroIntensity
requested review from
brettcannon,
markshannon,
ncoghlan and
warsaw
as code owners
Contributor
|
Please update |
Catching signals while another interpreter has registered `signal` module handlers still does not work, because we don't have a good way to make the callbacks per-interpreter. We'd need something like PEP 788's weak reference API to safely keep references to interpreters without worrying about concurrent deallocation during signal handling.
Member
Author
Updated. Note that there are still some bugs with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
PyInterpreterConfig.can_handle_signalsto make it possible for a subinterpreter to handle signals when it's running on the main thread. All interpreters created byconcurrent.interpretersnow include signal handling by default.📚 Documentation preview 📚: https://cpython-previews--137174.org.readthedocs.build/