Skip to content

gh-137920: Fix semantically relevant typo in curses.window.attron#137940

Merged
picnixz merged 1 commit intopython:mainfrom
vict-Yang:fix_typo_in_cursers.window.attron
Aug 22, 2025
Merged

gh-137920: Fix semantically relevant typo in curses.window.attron#137940
picnixz merged 1 commit intopython:mainfrom
vict-Yang:fix_typo_in_cursers.window.attron

Conversation

@vict-Yang
Copy link
Copy Markdown
Contributor

@vict-Yang vict-Yang commented Aug 19, 2025 •
edited by github-actions bot
Loading

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Aug 19, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Aug 19, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Aug 19, 2025
Closed
@StanFromIreland StanFromIreland changed the title gh-137920: Fix semantically relevant typo gh-137920: Fix semantically relevant typo in curses.window.attron Aug 19, 2025
@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented Aug 19, 2025

You need to sign the CLA.

serhiy-storchaka
serhiy-storchaka approved these changes Aug 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is clearly a copying error from attroff.

LGTM. 👍

@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 19, 2025
@picnixz picnixz merged commit ce70a57 into python:main Aug 22, 2025
57 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Aug 22, 2025

Thanks @vict-Yang for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Aug 22, 2025

Sorry, @vict-Yang and @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ce70a57bc02fddc8cb18a08aaf1449fceb10d66e 3.14

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Aug 22, 2025

Sorry, @vict-Yang and @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ce70a57bc02fddc8cb18a08aaf1449fceb10d66e 3.13

@picnixz
Copy link
Copy Markdown
Member

picnixz commented Aug 22, 2025

Of course. The backports.

@picnixz
Copy link
Copy Markdown
Member

picnixz commented Aug 22, 2025

@vict-Yang are you interested in making the backports PR (https://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes) or do you want me to do it?

@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented Aug 22, 2025

We should improve Miss Islington to update them.

@picnixz
Copy link
Copy Markdown
Member

picnixz commented Aug 22, 2025 •
edited
Loading

git itself fails to cleanly merge the commit without conflicts so I don't think we should do something smarter. It's sometimes very hard to decide how to solve conflicts (sometimes it's more than just selecting what needs to be selected).

@vict-Yang vict-Yang deleted the fix_typo_in_cursers.window.attron branch August 22, 2025 11:48
@vict-Yang vict-Yang restored the fix_typo_in_cursers.window.attron branch August 22, 2025 11:48
@vict-Yang vict-Yang deleted the fix_typo_in_cursers.window.attron branch August 22, 2025 11:53
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Sep 4, 2025
@vict-Yang @StanFromIreland
pythongh-137920: Fix semantically relevant typo in `curses.window.att…
58ca9f7 
…ron` (python#137940)

(cherry picked from commit ce70a57)
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Sep 4, 2025

GH-138506 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 4, 2025
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Sep 4, 2025

GH-138507 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 4, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Sep 4, 2025
@vict-Yang @StanFromIreland
[3.13] pythongh-137920: Fix semantically relevant typo in `curses.win…
19f0019 
…dow.attron` (pythonGH-137940)

(cherry picked from commit ce70a57)

Co-authored-by: vict-Yang <105902098+vict-Yang@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Sep 29, 2025
@StanFromIreland
pythongh-137920: Fix semantically relevant typo in `curses.window.att…
88f4b52 
…ron` (python#137940)

Originally authored by: vict-Yang

(cherry picked from commit ce70a57)
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Sep 29, 2025
@StanFromIreland
[3.13] pythongh-137920: Fix semantically relevant typo in `curses.win…
fb10895 
…dow.attron` (pythonGH-137940)

Originally authored by: vict-Yang

(cherry picked from commit ce70a57)
encukou pushed a commit that referenced this pull request Oct 7, 2025
@StanFromIreland
[3.14] gh-137920: Fix semantically relevant typo in curses.window.att…
537b558 
…ron (#137940) (GH-138506)

Originally authored by: vict-Yang

(cherry picked from commit ce70a57)
encukou pushed a commit that referenced this pull request Oct 7, 2025
@StanFromIreland
[3.13] gh-137920: Fix semantically relevant typo in `curses.window.at…
0404ca7 
…tron` (GH-137940) (GH-138507)

Originally authored by: vict-Yang

(cherry picked from commit ce70a57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vict-Yang @StanFromIreland @picnixz @serhiy-storchaka