gh-131323: Add comprehensive key-value type documentation to dbm module#137972
Open
furkanonder wants to merge 9 commits intopython:mainfrom
Open
gh-131323: Add comprehensive key-value type documentation to dbm module#137972furkanonder wants to merge 9 commits intopython:mainfrom
furkanonder wants to merge 9 commits intopython:mainfrom
Conversation
furkanonder
requested review from
erlend-aasland and
serhiy-storchaka
as code owners
furkanonder
added
needs backport to 3.13
eendebakpt
reviewed
Nov 2, 2025
Doc/library/dbm.rst
Outdated
|
|
||
| **Keys:** | ||
|
|
||
| * **All backends**: Accept :class:`str` and :class:`bytes` objects |
Contributor
There was a problem hiding this comment.
The sqlite backend accepts integers and floats as keys, but that is not mentioned here.
The structure for the Keys and Values section is slightly different, it would be nice to have them the same. Are there any differences in how keys and values are handled? If not, we might even combine the keys and values sections.
Contributor
Author
There was a problem hiding this comment.
Thanks. I've updated the doc to reflect that SQLite accepts int/float (and the other listed types) for both keys and values, an kept a single combined keys/values section since they're handled the same. I also increased test coverage for those key/value types.
eendebakpt
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbmsince 3.13 #131323📚 Documentation preview 📚: https://cpython-previews--137972.org.readthedocs.build/