Skip to content

gh-110936: Improve string literal definition in Lexical Analysis#138063

Merged
encukou merged 1 commit intopython:mainfrom
StanFromIreland:lex-ana-order
Sep 2, 2025
Merged

gh-110936: Improve string literal definition in Lexical Analysis#138063
encukou merged 1 commit intopython:mainfrom
StanFromIreland:lex-ana-order

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Aug 22, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 22, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Aug 22, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 22, 2025
Closed
@AA-Turner
Copy link
Copy Markdown
Member

AA-Turner commented Aug 22, 2025

cc @encukou, we've just reworded this section.

Perhaps this PR should be deferred in favour of the eventual goal of automatically generating the grammar snippets in the documentation for the actual grammar?

A

@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Aug 22, 2025 •
edited
Loading

After all of the work put in to improve the snippets, I think it would be worse as the actual grammar would be much less reader friendly.

Furthermore, for this specific case the parsing is done by string_parser.c (IIRC the name) and is not explicitly defined in the grammar.

@encukou
Copy link
Copy Markdown
Member

encukou commented Sep 2, 2025

Pablo's comment from the issue -- “The change is not incorrect and is technically a bit more precise on the order” -- applies to this one as well.
It's a small improvement, but let's still merge it.

@encukou encukou merged commit 0a0cbd4 into python:main Sep 2, 2025
34 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Sep 2, 2025
@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Sep 2, 2025

Per comment on issue.

@StanFromIreland StanFromIreland added the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Sep 2, 2025

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@StanFromIreland StanFromIreland deleted the lex-ana-order branch September 2, 2025 12:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2025
@StanFromIreland @miss-islington
pythongh-110936: Reorder string literal definition in Lexical Analysis (
836ac8e 
pythonGH-138063)

(cherry picked from commit 0a0cbd4)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Sep 2, 2025

GH-138373 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@StanFromIreland @lkollar
pythongh-110936: Reorder string literal definition in Lexical Analysis (
650d0e0 
pythonGH-138063)
hugovk pushed a commit that referenced this pull request Sep 16, 2025
@miss-islington @StanFromIreland
[3.14] gh-110936: Reorder string literal definition in Lexical Analys…
284ab76 
…is (GH-138063) (#138373)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

@pablogsal pablogsal Awaiting requested review from pablogsal

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @AA-Turner @encukou