gh-138712: Add os.NODEV#138728
Conversation
serhiy-storchaka
force-pushed
the
os-NODEV
branch
from
7063cfd to
2ba5b75
Compare
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Can you document the new constant in https://docs.python.org/dev/whatsnew/3.15.html#improved-modules ?
| if (hasattr(posix, 'NODEV') and | ||
| sys.platform.startswith(('linux', 'macos', 'freebsd', 'dragonfly', | ||
| 'sunos'))): | ||
| NODEV = posix.NODEV |
There was a problem hiding this comment.
Is this code path still skipped on Alpine Linux (musl)?
There was a problem hiding this comment.
It is skipped if NODEV is not defined in musl. But if it is defined, the following tests will fail, so we will need to add an additional condition.
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
This change is too minor. I don't think it deserves a separate What's New entry. I am not sure that What's New entries were added for every new constant.
| if (hasattr(posix, 'NODEV') and | ||
| sys.platform.startswith(('linux', 'macos', 'freebsd', 'dragonfly', | ||
| 'sunos'))): | ||
| NODEV = posix.NODEV |
There was a problem hiding this comment.
It is skipped if NODEV is not defined in musl. But if it is defined, the following tests will fail, so we will need to add an additional condition.
|
!buildbot alpine |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2ba5b75 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138728%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I didn't see Alpine Linux buildbot results. Alpine (musl) can be fixed later if needed.
|
I seen that test_posix passed on the Alpine Linux buildbot (unrelated tests failed). |
3 participants
📚 Documentation preview 📚: https://cpython-previews--138728.org.readthedocs.build/