gh-138736: Fix sqlite3.Connection.blobopen *row* type and naming

[chirizxc]

• Issue: wrong type of row in sqlite3.Connection.blobopen #138736

---

📚 Documentation preview 📚: https://cpython-previews--138738.org.readthedocs.build/

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[picnixz]

Err.... Actually... I'm very sorry but I think we should use the term "id". Here what I mean. The sqlite docs (https://sqlite.org/c3ref/blob_open.html) say ROWID (https://sqlite.org/lang_createtable.html#rowid). I think it's more precise than index because nothing guarantees that the first row has index 1 and there are tables without indices.

More precisely, the sqlite3 docs say:

This interfaces opens a handle to the BLOB located in row iRow, column zColumn, table zTable in database zDb; in other words, the same BLOB that would be selected by:

SELECT zColumn FROM zDb.zTable WHERE rowid = iRow;

For instance in https://sqlite.org/queryplanner.html#_lookup_by_rowid, the rowId does not match the "index" if we were to consider the table as an array. So maybe ID is better (and the C code could be improved instead).

cc @erlend-aasland

[erlend-aasland]

Let's go with rowid, since that's what it is (according to the SQLite docs).

[erlend-aasland]

We should also fix the docstring. And I'm inclined to also improve the parameter name (rename it from row to rowid), for improved clarity.

[erlend-aasland]

Thanks, @chirizxc!

[bedevere-app]

GH-139062 is a backport of this pull request to the 3.14 branch.

[bedevere-app]

GH-139063 is a backport of this pull request to the 3.13 branch.