gh-117961: Fix grammar documentation for @ operator associativity#138847
Open
guan404ming wants to merge 2 commits intopython:mainfrom
Open
gh-117961: Fix grammar documentation for @ operator associativity#138847guan404ming wants to merge 2 commits intopython:mainfrom
guan404ming wants to merge 2 commits intopython:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
b02eeb1 to
925a1c4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Author
|
Should I add NEWS entry here? I think the change only has little change for users so I didn’t add it for now. If needed, please kindly let me know, thanks! |
b09e5a4 to
e0c6f50
Compare
This comment was marked as resolved.
This comment was marked as resolved.
e0c6f50 to
d786fd1
Compare
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
d786fd1 to
a804783
Compare
Member
|
Please stop updating the branch, it uses up valuable resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary arithmetic operations grammar incorrectly showed the @ operator as right-associative (m_expr "@" m_expr) while all other multiplicative operators are left-associative (m_expr "*" u_expr).
According to PEP 465, the @ operator should have the same associativity as *. The actual parser implementation in Grammar/python.gram correctly implements left-associativity, but the documentation was inconsistent.
📚 Documentation preview 📚: https://cpython-previews--138847.org.readthedocs.build/