GH-139174: Add pathlib.Path.info.mode()#139183
Draft
barneygale wants to merge 2 commits intopython:mainfrom
Draft
GH-139174: Add pathlib.Path.info.mode()#139183barneygale wants to merge 2 commits intopython:mainfrom
pathlib.Path.info.mode()#139183barneygale wants to merge 2 commits intopython:mainfrom
Conversation
Add `mode()` method to the `PathInfo` protocol. A concrete implementation is available via `Path.info.mode()`. This method caches and returns the Posix file permissions, i.e. `st_mode` from the stat struct with its file format bits masked out. In the tests for the pathlib ABCs, add `mode()` methods to our `ZipPathInfo` and `LocalPathInfo` classes, and test them from `test_read`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
mode()method to thePathInfoprotocol. A concrete implementation is available viaPath.info.mode(). This method caches and returns the Posix file permissions, i.e.st_modefrom the stat struct with its file format bits masked out.In the tests for the pathlib ABCs, add
mode()methods to ourZipPathInfoandLocalPathInfoclasses, and test them fromtest_read.pathlib.Path.info#139174📚 Documentation preview 📚: https://cpython-previews--139183.org.readthedocs.build/