Replace type with types for the explanation type hint in glossary.rst#141668
Closed
hyperkai wants to merge 1 commit intopython:mainfrom
Closed
Replace type with types for the explanation type hint in glossary.rst#141668hyperkai wants to merge 1 commit intopython:mainfrom
type with types for the explanation type hint in glossary.rst#141668hyperkai wants to merge 1 commit intopython:mainfrom
Conversation
bedevere-app
bot
added
awaiting review
docs
|
|
||
| type hint | ||
| An :term:`annotation` that specifies the expected type for a variable, a class | ||
| An :term:`annotation` that specifies the expected types for a variable, a class |
Member
There was a problem hiding this comment.
IMO, the current one makes sense, if we take for example x: int | None than "int | None" is a typing.Union, i.e. a single object. Similarly, the union of two sets is a set, not sets.
Member
|
The current text is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced
typewithtypesfor the explanation type hint inglossary.rstbecause a type hint can have multiple(one or more) types.📚 Documentation preview 📚: https://cpython-previews--141668.org.readthedocs.build/