Skip to content

Conversation

@cocolato
Copy link
Contributor

@cocolato cocolato commented Jan 11, 2026

@python-cla-bot
Copy link

python-cla-bot bot commented Jan 11, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@cocolato
Copy link
Contributor Author

@Fidget-Spinner There may be many details that need fixing, and I hope you can give me some suggestions.

@cocolato
Copy link
Contributor Author

cocolato commented Jan 11, 2026

I haven't yet removed the cases of REPLACE_OP((inst+1),...), perhaps there's a better way to achieve this.

REPLACE_OP((this_instr+1), _EXIT_TRACE, 0, 0);

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is really valuable work. We definitely need this.

@cocolato
Copy link
Contributor Author

cocolato commented Jan 11, 2026

Thanks for taking the time to review this! I will rewrite them later.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite close.

@cocolato
Copy link
Contributor Author

cocolato commented Jan 12, 2026

Updated, thanks for your patient guidance!

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, last few minor comments. then I think this is ready to merge.

Thank you for your patience in enduring my comments :).

@cocolato
Copy link
Contributor Author

I may have misunderstood the previous comment. Thank you again for your guidance!

@Fidget-Spinner
Copy link
Member

Will leave this open for three days in case any other people want to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants