-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143421: Use new buffer to save optimized uops #143682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Fidget-Spinner There may be many details that need fixing, and I hope you can give me some suggestions. |
|
I haven't yet removed the cases of cpython/Python/optimizer_analysis.c Line 244 in 03e6457
|
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is really valuable work. We definitely need this.
|
Thanks for taking the time to review this! I will rewrite them later. |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite close.
|
Updated, thanks for your patient guidance! |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, last few minor comments. then I think this is ready to merge.
Thank you for your patience in enduring my comments :).
|
I may have misunderstood the previous comment. Thank you again for your guidance! |
|
Will leave this open for three days in case any other people want to review. |
Uh oh!
There was an error while loading. Please reload this page.