Skip to content

gh-144766: Fix flaky test_trampoline_works_with_forks #148056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yonatan-genai wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −2
Open

gh-144766: Fix flaky test_trampoline_works_with_forks #148056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9b8d13
gh-144766: Fix flaky test_trampoline_works_with_forks
yonatan-genai Apr 3, 2026
d9fa578
Add flush=True before os._exit and add NEWS entry
yonatan-genai Apr 3, 2026
838fc7e
Merge branch 'main' into gh-144766-fix-fork-test
yonatan-genai Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Lib/test/test_perf_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,14 @@ def baz_fork():
def foo():
pid = os.fork()
if pid == 0:
print(os.getpid())
print(os.getpid(), flush=True)
baz_fork()
os._exit(0)
else:
_, status = os.waitpid(-1, 0)
sys.exit(status)
if os.WIFSIGNALED(status):
sys.exit(1)
sys.exit(os.WEXITSTATUS(status))
def bar():
foo()
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-04-04-00-00-00.gh-issue-144766.Yk3mPq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix flaky :func:`test_trampoline_works_with_forks` by using ``os._exit(0)``
Copy link
Copy Markdown
Member

@webknjaz webknjaz Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roles like func can only link against objects Sphinx knows of. Test functions aren't usually documented.

in the fork child to avoid fragile Python finalization, and by flushing
stdout before exit. Also fix the parent's wait status handling to use
``os.WEXITSTATUS()``.
Copy link
Copy Markdown
Member

@webknjaz webknjaz Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
``os.WEXITSTATUS()``.
:func:`os.WEXITSTATUS`.

Might work, though.

Loading