Skip to content

gh-142927: Add scrollbar support to Tachyon HTML dark mode#148118

Open
Wulian233 wants to merge 2 commits intopython:mainfrom
Wulian233:scrollbar
Open

gh-142927: Add scrollbar support to Tachyon HTML dark mode#148118
Wulian233 wants to merge 2 commits intopython:mainfrom
Wulian233:scrollbar

Conversation

@Wulian233
Copy link
Copy Markdown
Contributor

@Wulian233 Wulian233 commented Apr 5, 2026

@hugovk

For compatibility, both approaches must be retained here.

::-webkit-scrollbar offers the widest compatibility, but requires fully customizing the scrollbar.
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/::-webkit-scrollbar#browser_compatibility
2026-04-04 174623


scrollbar-color is the newer standard, allowing us to style scrollbars without full customization. However, it is not supported by browsers from several years ago.

https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/scrollbar-color#browser_compatibility
2026-04-04 174610

@Wulian233 Wulian233 requested a review from pablogsal as a code owner April 5, 2026 02:42
@bedevere-app bedevere-app bot mentioned this pull request Apr 5, 2026
11 tasks
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Apr 5, 2026

These also apply to light mode, should they? And also * applies to every element.

But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see.

@Wulian233
Copy link
Copy Markdown
Contributor Author

Wulian233 commented Apr 5, 2026

I adjusted the scope and now only add it where needed

But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see.

This has been reused according to the existing heatmap design standards, so they should not have much impact:)

/* Scrollbar Styling */
.line-content::-webkit-scrollbar {
height: 6px;
}
.line-content::-webkit-scrollbar-thumb {
background: var(--border);
border-radius: 3px;
}
.line-content::-webkit-scrollbar-thumb:hover {
background: var(--text-muted);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants