Add __hash__ method to jwcrypto.jwk.JWK such that it satisfies Hashable interface to be used as dictionary key#15782
Open
jonathandung wants to merge 4 commits into
Open
Add __hash__ method to jwcrypto.jwk.JWK such that it satisfies Hashable interface to be used as dictionary key#15782jonathandung wants to merge 4 commits into
__hash__ method to jwcrypto.jwk.JWK such that it satisfies Hashable interface to be used as dictionary key#15782jonathandung wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
|
For reference, I've just filed python/typing#2284 and left a comment on python/mypy#4266 for the mypy errors. For now |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
May 12, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Looks mostly good, one nit.
Contributor
Author
|
I'm sorry, but I can't see what changes you've requested. |
srittau
reviewed
May 12, 2026
| def from_password(cls, password: str) -> Self: ... | ||
| def setdefault(self, key: str, default: _T | None = None) -> _T: ... | ||
| def __hash__(self) -> int: ... # type: ignore[override] | ||
| def __eq__(self, other: object, /) -> bool: ... |
Collaborator
There was a problem hiding this comment.
Nit: This is inherited from dict and doesn't need repeating here.
Collaborator
|
It seems I forgot to click a button. The comment is now visible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #15754