Skip to content

chore(ios): rebrand bundle ID to com.shivshankartiwari.ignitekit #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pythonsst merged 1 commit into from
Jun 6, 2026
Merged

chore(ios): rebrand bundle ID to com.shivshankartiwari.ignitekit #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 14 additions & 39 deletions android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,16 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<uses-permission android:name="android.permission.INTERNET" />

<application
android:name=".MainApplication"
android:label="@string/app_name"
android:icon="@mipmap/ic_launcher"
android:roundIcon="@mipmap/ic_launcher_round"
android:allowBackup="false"
android:theme="@style/AppTheme"
android:supportsRtl="true">
<meta-data
android:name="expo.modules.updates.ENABLED"
android:value="true" />
<meta-data
android:name="expo.modules.updates.EXPO_RUNTIME_VERSION"
android:value="1.0.0" />
<meta-data
android:name="expo.modules.updates.EXPO_UPDATES_CHECK_ON_LAUNCH"
android:value="ALWAYS" />
<meta-data
android:name="expo.modules.updates.EXPO_UPDATES_LAUNCH_WAIT_MS"
android:value="0" />
<meta-data
android:name="expo.modules.updates.EXPO_UPDATE_URL"
android:value="https://u.expo.dev/81e7f11f-c57a-420e-ae2a-b564c882828a" />
<activity
android:name=".MainActivity"
android:label="@string/app_name"
android:configChanges="keyboard|keyboardHidden|orientation|screenLayout|screenSize|smallestScreenSize|uiMode"
android:launchMode="singleTask"
android:windowSoftInputMode="adjustResize"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
</application>
<uses-permission android:name="android.permission.INTERNET"/>
<application android:name=".MainApplication" android:label="@string/app_name" android:icon="@mipmap/ic_launcher" android:roundIcon="@mipmap/ic_launcher_round" android:allowBackup="false" android:theme="@style/AppTheme" android:supportsRtl="true">
<meta-data android:name="expo.modules.updates.ENABLED" android:value="true"/>
<meta-data android:name="expo.modules.updates.EXPO_RUNTIME_VERSION" android:value="@string/expo_runtime_version"/>
<meta-data android:name="expo.modules.updates.EXPO_UPDATES_CHECK_ON_LAUNCH" android:value="ALWAYS"/>
<meta-data android:name="expo.modules.updates.EXPO_UPDATES_LAUNCH_WAIT_MS" android:value="0"/>
<meta-data android:name="expo.modules.updates.EXPO_UPDATE_URL" android:value="https://u.expo.dev/81e7f11f-c57a-420e-ae2a-b564c882828a"/>
<activity android:name=".MainActivity" android:label="@string/app_name" android:configChanges="keyboard|keyboardHidden|orientation|screenLayout|screenSize|smallestScreenSize|uiMode" android:launchMode="singleTask" android:windowSoftInputMode="adjustResize" android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN"/>
<category android:name="android.intent.category.LAUNCHER"/>
</intent-filter>
</activity>
</application>
</manifest>
3 changes: 2 additions & 1 deletion android/app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<resources>
<string name="app_name">ReactNativeIgniteKit</string>
<string name="app_name">ReactNativeIgniteKit</string>
<string name="expo_runtime_version">1.0.0</string>
</resources>
2 changes: 1 addition & 1 deletion app.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ module.exports = {
package: 'com.shivshankartiwari.reactnativeignitekit',
},
ios: {
bundleIdentifier: 'com.educatorslabs.ignitekit',
bundleIdentifier: 'com.shivshankartiwari.ignitekit',
},
};
6 changes: 3 additions & 3 deletions eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"ios": {
"ascAppId": "6761337270",
"bundleIdentifier": "com.educatorslabs.ignitekit"
"bundleIdentifier": "com.shivshankartiwari.ignitekit"
}
},
"staging": {
Expand All @@ -73,7 +73,7 @@
},
"ios": {
"ascAppId": "6761337270",
"bundleIdentifier": "com.educatorslabs.ignitekit"
"bundleIdentifier": "com.shivshankartiwari.ignitekit"
}
},
"production": {
Expand All @@ -84,7 +84,7 @@
},
"ios": {
"ascAppId": "6761337270",
"bundleIdentifier": "com.educatorslabs.ignitekit"
"bundleIdentifier": "com.shivshankartiwari.ignitekit"
}
}
}
Expand Down
20 changes: 10 additions & 10 deletions ios/IgniteKit.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@
"$(inherited)",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/IgniteKit.app/IgniteKit";
Expand All @@ -1063,7 +1063,7 @@
"$(inherited)",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/IgniteKit.app/IgniteKit";
Expand Down Expand Up @@ -1093,7 +1093,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = IgniteKit;
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Expand Down Expand Up @@ -1122,7 +1122,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = IgniteKit;
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
Expand Down Expand Up @@ -1154,7 +1154,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Expand Down Expand Up @@ -1187,7 +1187,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -1220,7 +1220,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Expand Down Expand Up @@ -1253,7 +1253,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -1284,7 +1284,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_DEBUG";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -1314,7 +1314,7 @@
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.educatorslabs.ignitekit;
PRODUCT_BUNDLE_IDENTIFIER = com.shivshankartiwari.ignitekit;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
VERSIONING_SYSTEM = "apple-generic";
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"screenshots:help": "cat docs/SCREENSHOTS.md",
"screenshots:1:build": "xcodebuild -workspace ios/IgniteKit.xcworkspace -scheme 'IgniteKit staging' -configuration Release -sdk iphonesimulator -derivedDataPath ios/simulator-build CODE_SIGNING_ALLOWED=NO | grep -E 'error:|Build succeeded|Build FAILED'",
"screenshots:2:capture": "bash scripts/capture-screenshots.sh",
"screenshots:3:upload:ios": "[ -f ./asc-api-key.json ] || (echo 'Error: asc-api-key.json not found. See docs/SCREENSHOTS.md.' && exit 1) && bundle exec fastlane run deliver api_key_path:./asc-api-key.json app_identifier:com.educatorslabs.ignitekit screenshots_path:./screenshots/ios skip_binary_upload:true skip_metadata:true overwrite_screenshots:true ignore_language_directory_validation:true force:true precheck_include_in_app_purchases:false",
"screenshots:3:upload:ios": "[ -f ./asc-api-key.json ] || (echo 'Error: asc-api-key.json not found. See docs/SCREENSHOTS.md.' && exit 1) && bundle exec fastlane run deliver api_key_path:./asc-api-key.json app_identifier:com.shivshankartiwari.ignitekit screenshots_path:./screenshots/ios skip_binary_upload:true skip_metadata:true overwrite_screenshots:true ignore_language_directory_validation:true force:true precheck_include_in_app_purchases:false",
"screenshots:3:upload:android": "bundle exec fastlane run supply --skip_upload_apk --skip_upload_aab --skip_upload_metadata --sync_image_upload true",
"screenshots:all": "yarn screenshots:1:build && yarn screenshots:2:capture && yarn screenshots:3:upload:ios"
},
Expand Down
Loading