fix(scanning): make first discovered device actionable#150
Merged
Conversation
Pressing Enter on the first device in the scanning pane did nothing until the selection was moved down and back up. TableState implements Copy, so the initial selection was applied only to an independent local copy used for rendering. The row appeared selected, but the pairing handler still saw no selected device. Persist the initial selection in new_devices_state and only select row zero when at least one device exists.
Contributor
Author
|
I suspect this is the correct fix for #135 |
Contributor
Author
|
Also a release would be nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter on the first device in the scanning pane did nothing until the selection was moved down and back up.
TableState implements Copy, so the initial selection was applied only to an independent local copy used for rendering. The row appeared selected, but the pairing handler still saw no selected device.
Persist the initial selection in new_devices_state and only select row zero when at least one device exists.