Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously suggested that compositions should be iterable in issue #553
I decided to see what that would look like, and have included the code here. The change is pretty trivial (adding an
__iter__function to the Compose object) and I went ahead and simplified the__doc__,__name__, and__repr__functions to take advantage of the fact that you can just useselfas an iterable to removereversed((first,)+funcs).I don't know how your tests work, but it seems to work fine with all my code. The only way I can imagine this breaking anything is if the code ever checks for iterability to decide if something is a Compose object, but I didn't see anything like that.