This PR Improve docs build ci #1336
Merged
Merged
Conversation
✅ Deploy Preview for pytorch-examples-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvrogozh
suggested changes
May 2, 2025
dvrogozh
reviewed
May 2, 2025
dvrogozh
reviewed
May 2, 2025
dvrogozh
reviewed
May 2, 2025
Contributor
dvrogozh
left a comment
There was a problem hiding this comment.
Created
_staticdirectory to resolve warnings.
You don't do that in the PR. Or that's done implicit?
Fix documentation build: GitHub Actions, Sphinx 5.3.0, and theme comp…
I suggest to change PR title to "Improved documentation ci build"
Contributor
You don't have this in your PR code change. Did you forget to amend? |
Contributor
Author
Contributor
I overlooked it. Thank you for pointing out. |
dvrogozh
approved these changes
May 7, 2025
Contributor
dvrogozh
left a comment
There was a problem hiding this comment.
LGTM. @msaroufim, can you, please, take a look on this PR?
msaroufim
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR Improve docs build ci
Changes:
git,make,python3-venv) from the GitHub Actions workflow, as they are preinstalled onubuntu-latestrunners.panels_add_bootstrap_css_staticdirectory to resolve warnings.Testing:
make html(no errors/warnings).