Use torch.accelerator API in Siamese Network example#1337
Merged
Conversation
✅ Deploy Preview for pytorch-examples-preview canceled.
|
malfet
approved these changes
May 1, 2025
msaroufim
approved these changes
May 2, 2025
dvrogozh
reviewed
May 2, 2025
| help='disables CUDA training') | ||
| parser.add_argument('--no-mps', action='store_true', default=False, | ||
| help='disables macOS GPU training') | ||
| parser.add_argument('--accel', action='store_true', |
Contributor
There was a problem hiding this comment.
Similar to #1338 (comment). @eromomon : I did not see this PR before it got merged. But you've changed the default in this example. Previously acceleration was always used (if available) and there was a flag to disable it. Now default is to not use acceleration and there is a flag to enable it. I personally like new behavior better, but we need to change the CI script to reflect that and that was not done:
examples/run_python_examples.sh
Line 112 in 54e132e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Siamese Network example to utilize torch.accelerator API. torch.accelerator API allows to abstract some of the accelerator specifics in the user scripts. By leveraging this API, the code becomes more adaptable to various hardware accelerators.
CC: @msaroufim, @malfet, @dvrogozh