Decompose sigmoid to exp+reciprocal to fix U85 TABLE bug#19618
Decompose sigmoid to exp+reciprocal to fix U85 TABLE bug#19618christine-long-meta wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19618
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 38 Unrelated FailuresAs of commit 4a69581 with merge base 7355d7b ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105021646. |
This PR needs a
|
Summary: Add DecomposeSigmoidPass that decomposes sigmoid(x) into reciprocal(add(exp(neg(x)), 1)). This bypasses the broken Vela U85 sigmoid TABLE op by decomposing into primitive ops whose individual TABLE implementations work correctly on U85. The pass runs in both the TFA pipeline (before quantization, so exp/reciprocal get individually annotated for a16w8) and the TOSA pipeline (for FP path). Differential Revision: D105021646
84732c4 to
4a69581
Compare
Summary:
Add DecomposeSigmoidPass that decomposes sigmoid(x) into reciprocal(add(exp(neg(x)), 1)).
This bypasses the broken Vela U85 sigmoid TABLE op by decomposing into
primitive ops whose individual TABLE implementations work correctly on U85.
The pass runs in both the TFA pipeline (before quantization, so exp/reciprocal get
individually annotated for a16w8) and the TOSA pipeline (for FP path).
Differential Revision: D105021646