Skip to content

Fix portable pybindings COW ABI dependency #21019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakeStevens wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −6
Open

Fix portable pybindings COW ABI dependency #21019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions extension/pybindings/pybindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,22 @@ namespace pybindings {

namespace {

void* mutable_tensor_data_ptr_no_cow(at::Tensor& tensor) {
if (tensor.numel() == 0) {
return nullptr;
}

auto* storage_data = static_cast<char*>(tensor.unsafeGetTensorImpl()
->unsafe_storage()
.unsafeGetStorageImpl()
->_mutable_data_ptr_no_checks()
.mutable_get());
ET_CHECK_MSG(
storage_data != nullptr,
"Tensor has a non-zero number of elements, but its data is not allocated");
return storage_data + tensor.storage_offset() * tensor.itemsize();
}

void write_data_to_file(const std::string& path, void* buf, size_t size) {
FILE* f = fopen(path.c_str(), "w+");
if (!f) {
Expand Down Expand Up @@ -1117,12 +1133,14 @@ struct PyMethod final {
" should be contiguous or channels-last.";
throw std::runtime_error(error_msg);
}
TensorPtr tensor =
for_blob(at_tensor.data_ptr(), std::move(sizes), type)
.strides(std::move(strides))
.dim_order(std::move(dim_order))
.dynamism(aten::TensorShapeDynamism::STATIC)
.make_tensor_ptr();
TensorPtr tensor = for_blob(
mutable_tensor_data_ptr_no_cow(at_tensor),
std::move(sizes),
type)
.strides(std::move(strides))
.dim_order(std::move(dim_order))
.dynamism(aten::TensorShapeDynamism::STATIC)
.make_tensor_ptr();
input_tensors.push_back(tensor);
EValue evalue(input_tensors.back());
#endif
Expand Down
Loading