Skip to content

Two-pass optimization for channelwise gated delta rule kernel (#21020)#21020

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D112596724
Open

Two-pass optimization for channelwise gated delta rule kernel (#21020)#21020
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D112596724

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary:

Reduce the channelwise gated delta rule kernel from four state traversals to two per token. The first pass computes the predicted value while folding in decay; the second applies decay and the rank-one update while accumulating the output. This preserves operation grouping and numerical behavior while reducing state-memory traffic. Add a standalone microbenchmark covering decode and representative prefill lengths.

Differential Revision: D112596724

@pytorch-bot

pytorch-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21020

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Merge Blocking SEVs

There is 2 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 3 New Failures

As of commit baee844 with merge base 931ba24 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2026
@meta-codesync

meta-codesync Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112596724.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Two-pass optimization for channelwise gated delta rule kernel Two-pass optimization for channelwise gated delta rule kernel (#21020) Jul 17, 2026
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Jul 17, 2026
…h#21020)

Summary:

Reduce the channelwise gated delta rule kernel from four state traversals to two per token. The first pass computes the predicted value while folding in decay; the second applies decay and the rank-one update while accumulating the output. This preserves operation grouping and numerical behavior while reducing state-memory traffic. Add a standalone microbenchmark covering decode and representative prefill lengths.

Differential Revision: D112596724
…h#21020)

Summary:

Reduce the channelwise gated delta rule kernel from four state traversals to two per token. The first pass computes the predicted value while folding in decay; the second applies decay and the rank-one update while accumulating the output. This preserves operation grouping and numerical behavior while reducing state-memory traffic. Add a standalone microbenchmark covering decode and representative prefill lengths.

Differential Revision: D112596724
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Jul 17, 2026
…h#21020)

Summary:

Reduce the channelwise gated delta rule kernel from four state traversals to two per token. The first pass computes the predicted value while folding in decay; the second applies decay and the rank-one update while accumulating the output. This preserves operation grouping and numerical behavior while reducing state-memory traffic. Add a standalone microbenchmark covering decode and representative prefill lengths.

Differential Revision: D112596724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant