Remove 16 redundant skipped test stubs in test_scalars.py#21026
Conversation
Summary: These test functions are empty stubs (body=pass) that are permanently skipped because their functionality is tested by the corresponding _tosa_INT and _tosa_BI tests. Removing them reduces the ai_infra_mobile_platform oncall's SKIPPING count by 16. Differential Revision: D112509983
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21026
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use ❌ 2 New FailuresAs of commit 92c14ab with merge base 931ba24 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112509983. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Arm backend scalar-op test suite by removing redundant, permanently skipped (empty pass) Ethos-U scalar test stubs, reducing noise in test reporting.
Changes:
- Removed multiple
@pytest.mark.skip(...); def ...(): passEthos-U scalar test stubs for add/sub/mul/div INT. - Changed the FP-profile right-shift test marker from
skiptoxfail(..., strict=True)so it will execute and be expected to fail.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @pytest.mark.xfail( | ||
| reason="integer operations (shift and sub) are not supported on FP profile", | ||
| strict=True, | ||
| ) |
Summary: These test functions are empty stubs (body=pass) that are permanently skipped because their functionality is tested by the corresponding _tosa_INT and _tosa_BI tests. Removing them reduces the ai_infra_mobile_platform oncall's SKIPPING count by 16.
Differential Revision: D112509983
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani