Skip to content

Remove 16 redundant skipped test stubs in test_scalars.py#21026

Open
psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:export-D112509983
Open

Remove 16 redundant skipped test stubs in test_scalars.py#21026
psiddh wants to merge 1 commit into
pytorch:mainfrom
psiddh:export-D112509983

Conversation

@psiddh

@psiddh psiddh commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary: These test functions are empty stubs (body=pass) that are permanently skipped because their functionality is tested by the corresponding _tosa_INT and _tosa_BI tests. Removing them reduces the ai_infra_mobile_platform oncall's SKIPPING count by 16.

Differential Revision: D112509983

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Summary: These test functions are empty stubs (body=pass) that are permanently skipped because their functionality is tested by the corresponding _tosa_INT and _tosa_BI tests. Removing them reduces the ai_infra_mobile_platform oncall's SKIPPING count by 16.

Differential Revision: D112509983
@psiddh
psiddh requested a review from digantdesai as a code owner July 17, 2026 21:03
Copilot AI review requested due to automatic review settings July 17, 2026 21:03
@pytorch-bot

pytorch-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21026

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 2 New Failures

As of commit 92c14ab with merge base 931ba24 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2026
@meta-codesync

meta-codesync Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112509983.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the Arm backend scalar-op test suite by removing redundant, permanently skipped (empty pass) Ethos-U scalar test stubs, reducing noise in test reporting.

Changes:

  • Removed multiple @pytest.mark.skip(...); def ...(): pass Ethos-U scalar test stubs for add/sub/mul/div INT.
  • Changed the FP-profile right-shift test marker from skip to xfail(..., strict=True) so it will execute and be expected to fail.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +383 to 386
@pytest.mark.xfail(
reason="integer operations (shift and sub) are not supported on FP profile",
strict=True,
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants