Skip to content

Reland "Arm backend: Add transpose propagation pass" v2#21030

Open
rascani wants to merge 2 commits into
mainfrom
revert-20947-revert-20748-revert-20742-revert-20625-change-1265162
Open

Reland "Arm backend: Add transpose propagation pass" v2#21030
rascani wants to merge 2 commits into
mainfrom
revert-20947-revert-20748-revert-20742-revert-20625-change-1265162

Conversation

@rascani

@rascani rascani commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@pytorch-bot pytorch-bot Bot added the ci-no-td label Jul 17, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21030

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Pending, 1 Unclassified Failure

As of commit 0afc0d3 with merge base 8077bb6 (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

The view/permute propagation passes can rank-broadcast one operand of a binary elementwise op — a per-channel affine's activation becomes rank 4 while its scale/bias constant stays rank 1 — which TOSA rejects, so Vela/Regor fails to compile the graph. Running MatchArgRanksPass after propagation re-matches operand ranks and keeps the graph TOSA-legal. Adds a regression test that lowers a per-channel-affine module for Ethos-U55.

Authored with assistance from Claude.
@rascani
rascani force-pushed the revert-20947-revert-20748-revert-20742-revert-20625-change-1265162 branch from 1237969 to 0afc0d3 Compare July 17, 2026 23:15
@rascani

rascani commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Delta since last land here: 0afc0d3

@rascani
rascani marked this pull request as ready for review July 17, 2026 23:16
@rascani
rascani requested a review from digantdesai as a code owner July 17, 2026 23:16
@rascani
rascani requested a review from AdrianLundell July 17, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant