Skip to content

Fix printf format specifier mismatches#21034

Open
cyyever wants to merge 3 commits into
pytorch:mainfrom
cyyever:fix-format-strings
Open

Fix printf format specifier mismatches#21034
cyyever wants to merge 3 commits into
pytorch:mainfrom
cyyever:fix-format-strings

Conversation

@cyyever

@cyyever cyyever commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Fix printf format specifier mismatches (sign/size errors like PRIu64 for int64_t, %zd for size_t; malformed literals like 0x%x" PRIx32) across runtime, kernels, extensions, backends, and examples. Then enforce format checks as errors under GCC via _common_compile_options, since GCC checks no format strings by default. Verified by rebuilding with clang -Wformat=2 and syntax-checking all 255 first-party TUs with GCC's -Wformat-signedness — both clean.

Authored with Claude.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21034

Note: Links to docs will display an error until the docs builds have been completed.

❌ 58 New Failures, 110 Pending, 38 Unrelated Failures, 4 Unclassified Failures

As of commit afecdbd with merge base 5c9cd91 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 18, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

Workflows were awaiting approval. CI has now been triggered for the ciflow labels on this PR.

@cyyever

cyyever commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Jul 18, 2026
@nil-is-all nil-is-all added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: cleanup Issues/PRs which cleanup code across the repository and removed module: arm Issues related to arm backend labels Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: cleanup Issues/PRs which cleanup code across the repository release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants