Remove extra defensive checks on aten ops in annotator#21058
Remove extra defensive checks on aten ops in annotator#21058JakeStevens wants to merge 1 commit into
Conversation
Summary: When dim name was removed from PyTorch, a defensive check was added because there could be a window where an older PyTorch hash is used. This was intended to be removed after some time. The AIs then pattern match on this extra check and more have been added. Moving all back to the simple list of them; if an aten op is missing from PyTorch, it should be addressed directly instead. Differential Revision: D113019278
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21058
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New Failures, 1 Unrelated FailureAs of commit ac5448d with merge base 667c91b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113019278. |
This PR needs a
|
Summary:
When dim name was removed from PyTorch, a defensive check was added because there could be a window where an older PyTorch hash is used. This was intended to be removed after some time.
The AIs then pattern match on this extra check and more have been added.
Moving all back to the simple list of them; if an aten op is missing from PyTorch, it should be addressed directly instead.
Differential Revision: D113019278
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani