Skip to content

Remove extra defensive checks on aten ops in annotator#21058

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D113019278
Open

Remove extra defensive checks on aten ops in annotator#21058
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D113019278

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary:
When dim name was removed from PyTorch, a defensive check was added because there could be a window where an older PyTorch hash is used. This was intended to be removed after some time.

The AIs then pattern match on this extra check and more have been added.

Moving all back to the simple list of them; if an aten op is missing from PyTorch, it should be addressed directly instead.

Differential Revision: D113019278

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Summary:
When dim name was removed from PyTorch, a defensive check was added because there could be a window where an older PyTorch hash is used. This was intended to be removed after some time.

The AIs then pattern match on this extra check and more have been added.

Moving all back to the simple list of them; if an aten op is missing from PyTorch, it should be addressed directly instead.

Differential Revision: D113019278
@JakeStevens
JakeStevens requested a review from digantdesai as a code owner July 21, 2026 14:12
@pytorch-bot

pytorch-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21058

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures, 1 Unrelated Failure

As of commit ac5448d with merge base 667c91b (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • pull / test-multimodal-linux (gemma3-4b) / linux-job (gh)
    RuntimeError: Command docker exec -t 6c73614c8b7a95645daabfa31d52cefbe2b34158cf3d90ac33c4e3c5f43a8cea /exec failed with exit code 139
  • pull / unittest-buck / linux / linux-job (gh)
    RuntimeError: Command docker exec -t 3095891fc3ea946efa5ae9f246f855b4ae7457919942c884e9363a77637088ff /exec failed with exit code 3
  • trunk / unittest-release / windows / windows-job (gh)
    examples/models/test/test_export.py::ExportTest::test_vit_export_to_executorch

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 21, 2026
@meta-codesync

meta-codesync Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113019278.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant