Skip to content

Revert "Arm backend: Rerun duplicate-user fusion after TOSA lowering"#21106

Merged
metascroy merged 1 commit into
mainfrom
revert-21041-rerun-deplicate-user-fusion
Jul 21, 2026
Merged

Revert "Arm backend: Rerun duplicate-user fusion after TOSA lowering"#21106
metascroy merged 1 commit into
mainfrom
revert-21041-rerun-deplicate-user-fusion

Conversation

@metascroy

@metascroy metascroy commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Reverts #21041

This change breaks executorch/backends/arm/test:addmm
test_addmm_u55_INT[basic] on Corstone-300: the model output is all zeros
instead of the reference [[2,4],[6,8]].

Root cause: running FuseDuplicateUsersPass after InsertRescalePass. In the
[basic] case x1 and x3 are value-identical, so FuseEqualPlaceholdersPass
merges them into a single placeholder that feeds both the matmul operand
and the bias/add path. After rescale insertion, that shared producer has
multiple tosa.RESCALE users, and fusing them corrupts the quantized addmm
data flow, zeroing the output. Bisected to the late FuseDuplicateUsersPass
insertion specifically (reordering EnsureUniqueOutputNodesPass is not the
cause).

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@metascroy
metascroy requested a review from digantdesai as a code owner July 21, 2026 20:53
@pytorch-bot pytorch-bot Bot added the ci-no-td label Jul 21, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21106

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jul 21, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy
metascroy merged commit cd380e7 into main Jul 21, 2026
496 of 501 checks passed
@metascroy
metascroy deleted the revert-21041-rerun-deplicate-user-fusion branch July 21, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants