Revert "Arm backend: Rerun duplicate-user fusion after TOSA lowering"#21106
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21106
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rascani
approved these changes
Jul 21, 2026
Gasoonjia
approved these changes
Jul 21, 2026
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #21041
This change breaks executorch/backends/arm/test:addmm
test_addmm_u55_INT[basic] on Corstone-300: the model output is all zeros
instead of the reference [[2,4],[6,8]].
Root cause: running FuseDuplicateUsersPass after InsertRescalePass. In the
[basic] case x1 and x3 are value-identical, so FuseEqualPlaceholdersPass
merges them into a single placeholder that feeds both the matmul operand
and the bias/add path. After rescale insertion, that shared producer has
multiple tosa.RESCALE users, and fusing them corrupts the quantized addmm
data flow, zeroing the output. Bisected to the late FuseDuplicateUsersPass
insertion specifically (reordering EnsureUniqueOutputNodesPass is not the
cause).
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani