Skip to content

Forward fix for broken update and attend test#21292

Closed
kiymetakdemir wants to merge 1 commit into
pytorch:mainfrom
kiymetakdemir:export-D113428489
Closed

Forward fix for broken update and attend test#21292
kiymetakdemir wants to merge 1 commit into
pytorch:mainfrom
kiymetakdemir:export-D113428489

Conversation

@kiymetakdemir

Copy link
Copy Markdown
Contributor

Summary:
[executorch] Add missing exir:_warnings dep to llm cache library

The cache python_library sources reference_cache.py, which imports
from executorch.exir._warnings import experimental for the experimental decorators on CacheConfig and ContiguousReferenceCache. The target only
depended on //caffe2:torch, so executorch.exir was absent at runtime and every test in test_update_and_attend failed at import with
ModuleNotFoundError: No module named 'executorch.exir'.

Add //executorch/exir:_warnings to the cache library's deps.

Reviewed By: metascroy

Differential Revision: D113428489

Summary:
[executorch] Add missing exir:_warnings dep to llm cache library

The `cache` python_library sources `reference_cache.py`, which imports
`from executorch.exir._warnings import experimental` for the `experimental` decorators on `CacheConfig` and `ContiguousReferenceCache`. The target only
depended on `//caffe2:torch`, so `executorch.exir` was absent at runtime and every test in `test_update_and_attend` failed at import with
`ModuleNotFoundError: No module named 'executorch.exir'`.

Add `//executorch/exir:_warnings` to the `cache` library's deps.

Reviewed By: metascroy

Differential Revision: D113428489
@pytorch-bot

pytorch-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21292

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 3b579dc with merge base 179c4ee (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2026
@meta-codesync

meta-codesync Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@kiymetakdemir has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113428489.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants