docs: opt-in EnableFast lane + contributor rules of engagement#85
Closed
akaszynski wants to merge 0 commit into
Closed
docs: opt-in EnableFast lane + contributor rules of engagement#85akaszynski wants to merge 0 commit into
akaszynski wants to merge 0 commit into
Conversation
f32d2f8 to
3174090
Compare
Member
Author
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the opt-in fast-filter approach established by the EnableFast PR stack (#81–#84) and rewrites
CONTRIBUTING.mdwith the rules of engagement for performance work.Targets
mainso it's independently mergeable (docs-only; describes the convention the stack follows).README
New lever "Opt-in fast lane —
fvtk.EnableFast()" under the runtime-speed levers:FastModeEnabled()/FVTK_FASTruntime toggle (read live, no rebuild);RunFastFilterParallelorder-relaxed threading, andFastModeEnabled()-gated vendored OpenMP kernels (pyvista-algorithms, MIT; non-unity TUs,FVTK_HAVE_OPENMP-guarded, fall back to stock for unsupported input);vtkDataSetSurfaceFilter,vtkStaticCleanUnstructuredGrid,vtkCleanPolyData;order_relaxed/points_relaxedvalidation modes + the engagement check (a relaxed test passes on the byte-exact fallback too, so it can't alone prove the kernel ran).Cross-referenced from Parity & validation (the bit-exact gate).
CONTRIBUTING
Replaces the stale stock-VTK GitLab boilerplate with fvtk's actual workflow and the rules of engagement:
EnableFast(), validated by the relaxed gate + engagement check.main.🤖 Generated with Claude Code