chore: remove redundant @types/node from workspace packages#906
Merged
Conversation
…ages - Remove @types/node from 6 packages (all now use hoisted version) - Fix qase-wdio: @types/node was incorrectly in dependencies - Update jest 27 -> 29 in qase-api-client and qase-api-v2-client to match root and eliminate local node_modules duplication Remaining local node_modules (different major versions, can't dedupe): - qase-javascript-commons: ajv@8 vs root ajv@6 (from eslint) - qase-wdio: strip-ansi@7 vs root strip-ansi@6
gibiw
force-pushed
the
chore/remove-redundant-types-node
branch
from
a3aea17 to
5db2d19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/nodefrom devDependencies in 5 packages (qase-api-client, qase-api-v2-client, qase-javascript-commons, qase-mocha, qase-vitest)@types/nodefrom dependencies in qase-wdio (was incorrectly in production deps)@types/node@25.xfrom rootWhy
Each package pinned its own
@types/nodeversion (12.x / 20.x), conflicting with the root-hoisted 25.x. This caused npm to create localnode_modulesdirectories in every package, duplicating the dependency tree.No user impact
devDependencies— not installed by consumers@types/nodewas independenciesby mistake (type definitions are not needed at runtime). Users already have@types/nodethrough their own projectsTest plan
node_modules/@types/nodein any workspace package